Verify auto-negotiated speed/duplex #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axkar
force-pushed
the
speed_duplex
branch
3 times, most recently
from
76d2a1c to
60e3fa0
Compare
wkz
requested changes
Jun 16, 2025
Contributor
wkz
left a comment
wkz
left a comment
There was a problem hiding this comment.
Looks good! 👏 👏
How big of an effort would it be to add tests for setting static speed duplex on the target side while we're at it?
mattiaswal
approved these changes
Jun 18, 2025
Collaborator
Author
Not much. I can add them :) |
axkar
force-pushed
the
speed_duplex
branch
2 times, most recently
from
f5c7a83 to
460a929
Compare
wkz
requested changes
Jun 24, 2025
test/case/ietf_interfaces/speed_duplex_copper/speed_duplex_copper.adoc
Outdated
Show resolved
Hide resolved
Add `ethtool` to the Docker test environment to support interface auto-negotiation tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that auto-negotiation results in expected speed/duplex mode.
Fixed #976
Checklist
Tick relevant boxes, this PR is-a or has-a: